Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ToggleSwitch): add support for a ref on the inner <button> element #3813

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

joshblack
Copy link
Member

Closes #3806

Changelog

New

Changed

  • ToggleSwitch now accepts a ref on the inner <button> element
  • Move ToggleSwitch test fixtures next to component

Removed

Rollout strategy

  • Minor release

Testing & Reviewing

  • Verify that ToggleSwitch supports ref
  • Verify that tests capture semantics of ref (specifically as a HTMLButtonElement)

@joshblack joshblack requested review from a team and josepmartins October 12, 2023 17:49
@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023

🦋 Changeset detected

Latest commit: a7903ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.77 KB (-0.01% 🔽)
dist/browser.umd.js 105.36 KB (-0.01% 🔽)

@joshblack joshblack temporarily deployed to github-pages October 12, 2023 17:57 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3813 October 12, 2023 17:57 Inactive
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a fix!

Optional feedback for a follow up PR: #3806 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to pass ref to ToggleSwitch
3 participants