Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircleBadge cleanup #332

Merged
merged 2 commits into from
Oct 25, 2018
Merged

CircleBadge cleanup #332

merged 2 commits into from
Oct 25, 2018

Conversation

emplums
Copy link

@emplums emplums commented Oct 25, 2018 •
edited
Loading

Removes the alt and src props as they aren't necessary - users can provide an image as a child instead of making the wrapper component an image. This cleans up the API so that there aren't multiple ways of doing the same thing 👍

Closes #254

Merge checklist

  • Changed base branch to release branch
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@emplums emplums requested a review from shawnbot October 25, 2018 21:16
@vercel
Copy link

vercel bot commented Oct 25, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

shawnbot
shawnbot approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@emplums emplums merged commit 467c8d9 into q4-haunted-kittens Oct 25, 2018
@emplums emplums deleted the circlebadge branch October 25, 2018 21:24
@emplums emplums mentioned this pull request Oct 26, 2018
Merged
5 tasks
siddharthkp added a commit that referenced this pull request Jan 11, 2022
@siddharthkp
use doctocat from #332
432176e
siddharthkp added a commit that referenced this pull request Jan 31, 2022
@siddharthkp
Docs: Remove drafts silliness from examples (#1785)
5e4b60c 
* use doctocat from #332

* make live-code a function

* update docs

* can make code inline now :)

* jsx instead of javascript

* Make the variable for adding drafts to scope more explicit

* Bring changes from 1778

* Add drafts to nav

* disable eslint/no-redeclare for code blocks

* revert explicit scope flag :)

* update gatsby-theme-doctocat

* sync lockfile

* fix bad merge

* make live-scope a function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbot shawnbot shawnbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emplums @shawnbot