Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release tracking #2636

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Release tracking #2636

merged 1 commit into from
Dec 5, 2022

Conversation

primer-css
Copy link
Contributor

@primer-css primer-css commented Dec 1, 2022 •
edited
Loading

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/react@35.15.1

Patch Changes

@primer-css primer-css requested review from a team and josepmartins December 1, 2022 21:14
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022 •
edited by siddharthkp
Loading

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass
  • Docs and Storybook open in a browser
  • Successful integration test with GitHub Projects as a primary consumer of Primer React https://github.com/github/memex/pull/13512
    • Install the Release Candidate
    • Verify no new build errors appear
    • Verify no new linting errors appear
    • Verify no new browser console errors appear
    • Verify unit tests and E2E tests pass
    • Manually test critical paths (Tip: Use the provided tests project boards)
    • Manually test release-specific bugfixes and/or features work as described
  • Works in CodeSandbox or StackBlitz (nope, hasn't been since 35.12.0 😢)
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🤔 Sanity test

  • All bugfixes in this release have resolved their corrosponding issues
  • All new features in this release have been tested and verified as compatible with GitHub Projects
  • No noticeable regressions have not been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

🚢 After merge

  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

Please also leave any testing notes as a comment on this pull request. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to maintainers.

@github-actions github-actions bot requested a review from colebemis December 1, 2022 21:15
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 78.95 KB (0%)
dist/browser.umd.js 79.58 KB (0%)

@primer-css primer-css temporarily deployed to github-pages December 1, 2022 21:22 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2636 December 1, 2022 21:22 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from e626a90 to 6317a22 Compare December 1, 2022 21:54
@primer-css primer-css temporarily deployed to github-pages December 1, 2022 22:01 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2636 December 1, 2022 22:01 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from 6317a22 to 646ce78 Compare December 2, 2022 01:02
@primer-css primer-css temporarily deployed to github-pages December 2, 2022 01:11 Inactive
@siddharthkp siddharthkp requested review from siddharthkp and removed request for josepmartins and colebemis December 5, 2022 15:28
@github-actions github-actions bot requested a review from colebemis December 5, 2022 15:29
siddharthkp
siddharthkp approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist complete :)

@siddharthkp siddharthkp merged commit 0cfdad8 into main Dec 5, 2022
@siddharthkp siddharthkp deleted the changeset-release/main branch December 5, 2022 15:37
@siddharthkp siddharthkp assigned siddharthkp and unassigned colebemis Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

@colebemis colebemis Awaiting requested review from colebemis

Assignees

@siddharthkp siddharthkp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@primer-css @siddharthkp @colebemis