-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActionList: Add keyboard accessibility #1603
Conversation
🦋 Changeset detectedLatest commit: 5500790 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Hey not sure if this is valid. What does inset mean anyways? Screen.Recording.2021-11-15.at.3.43.12.pm.mov |
The last option? Not sure how to adapt focus styles if the user has given custom styles to an Item with
inset children are offset (vertically and horizontally) from List’s edges, full children are flush (vertically and horizontally) with List edges. |
Part of https://github.com/github/primer/issues/447
Includes visual changes for keyboard focus from https://github.com/github/primer/issues/409
Please provide before/after screenshots for any visual changes
before:
tab.tab.fail.mov
after:
tabtab.mov
Merge checklist