Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActionList Composable API #1517
ActionList Composable API #1517
Changes from 86 commits
0876cef
6866c09
4d9d014
9119eea
e519b85
2224f84
fed8f51
0630556
4d1cc22
1c3ce94
b07feef
a6acb35
4dae4c7
ef8f3a2
cfd7e2d
1748dcf
bcdff11
a07abf3
0fc658d
2f3a8cd
0260e3a
72ef62d
d065a63
a82a3c5
1d57ed1
b7926ce
6a7110e
f69b7d5
3f77738
5ad3004
5c46373
d775083
901c109
769edb2
6840f12
ae97e51
199605e
be70024
8af4571
fce4049
249936a
3eb2c3e
c14da85
15334ef
69190d9
9462f46
fe56433
32a729d
00cbf63
2358926
9a9489e
569f633
868ebfd
fd99704
4d782d7
01ae72d
1b1d393
39cdf97
5bcb3a6
b08807d
96eb536
a8cf98e
dcc3baf
4acaa54
e5ae5e4
897d308
19b430b
853569c
8473500
9cb3517
01eab7c
4bd3c2d
f76d9c5
ee9b795
2ef3be1
76007b2
a86b13b
31b6809
3b83549
15ae268
c5cdff5
2541c94
8e538c0
02168c1
9672f10
0d97f39
1cd0d32
3dc13a2
2d13781
e8c3a5d
12da5b1
4870da1
b8ded7b
143e4c6
221edfe
5fb716d
cace4bb
99caa36
605044c
c812437
cacaec9
0e66876
dee7775
d16d2d9
ca4e451
1be1095
93561e7
4809068
0d0d1cb
5f38e76
1432420
9d14e5a
71bc34e
bacd12c
859008e
6d6ddf5
3cfc4f7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colebemis - should we track this component in the Primer React component status sheet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like
experiments
is in scope because it's imported indocs/src/@primer/gatsby-theme-doctocat/live-code-scope.js
Nitpick: If I'm not a regular contributor to Primer React, I might get confused about where
experiments
is defined when looking at the examples.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! I'd really like a way to hide that but not sure without calling making the jsx look like this: