Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes unused systemPropArray argument to behavesAsComponent #1473

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Removes unused systemPropArray argument to behavesAsComponent #1473

merged 1 commit into from
Sep 28, 2021

Conversation

jfuchs
Copy link
Contributor

@jfuchs jfuchs commented Sep 28, 2021

This argument wasn't being used.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@jfuchs jfuchs requested review from a team and smockle September 28, 2021 18:14
@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2021

⚠️ No Changeset found

Latest commit: efb49ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jfuchs jfuchs requested review from colebemis and removed request for smockle September 28, 2021 18:14
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 51.71 KB (0%)
dist/browser.umd.js 52 KB (0%)

colebemis
colebemis approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels so good to see all the 🟥 🟥 🟥 🔥

@jfuchs jfuchs merged commit f5a7c2e into main Sep 28, 2021
@jfuchs jfuchs deleted the jfuchs/remove-systemPropsArray branch September 28, 2021 18:22
colebemis added a commit that referenced this pull request Sep 29, 2021
@colebemis
Remove systemPropArray
8300aa3 
It was removed in #1473
colebemis added a commit that referenced this pull request Sep 30, 2021
@smockle @colebemis
feat: Focus the primary action in 'ConfirmationDialog' (#1471)
f1cebb7 
* feat: Focus the primary action in 'ConfirmationDialog'

* chore: Add changeset

* chore: Add tests for 'ConfirmationDialog'

* Remove systemPropArray

It was removed in #1473

Co-authored-by: Cole Bemis <colebemis@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfuchs @colebemis