Exclude storybook stories from TypeScript compilation for builds #1441
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of investigating TypeScript type questions with @colebemis, we noticed that building our typedefs with any Storybook story included would lead to some components gaining a css prop in their typedef. E.g., lib/Button/Button.d.ts would include the line:
And excluding all stories would give us a build without any
css
props attached to components. This solution should give us clean type defs in our builds while still allowing typechecking of stories. Some caveats:Closes #1163
Screenshots
😅
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.