-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate system props, but don't remove system props #1336
Conversation
🦋 Changeset detectedLatest commit: b4b0d1d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/8vinz2DFD83h5KTft9VC1ixCyTDb |
Much more tweaking on the codemod here, we should be to the place where running it on a production codebase like memex will only take about 15 minutes give or take of post codemod tweaking to get things right. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Remove deprecated use of `mr` system prop, instead using `sx`. Related PR: primer#1336
Remove deprecated use of `mr` system prop, instead using `sx`. Related PR: #1336 Co-authored-by: Josh Black <joshblack@github.com>
This PR deprecates system props in all components except
Box
, but does not actually remove them. A codemod with documentation is provided to enable users to easily make the transition.Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.