Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Custom elements example #13

Closed
wants to merge 5 commits into from
Closed

[WIP] Custom elements example #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c908dfd
update to react@16.3.0
shawnbot Apr 4, 2018
e36dae4
link styleguide.js and styleguide.css
shawnbot Apr 3, 2018
1ef0e4b
add octicons, <details-dialog>, .npmrc
shawnbot Apr 4, 2018
2e8e8f7
transform custom element classes :sparkles:
shawnbot Apr 4, 2018
e66606f
add <details-dialog>/<DetailsDialog> example
shawnbot Apr 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .babelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"plugins": [
"transform-custom-element-classes"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary to support babel's compilation of the custom element class definition because it scopes the HTMLElement identifier in such a way that causes JS errors. I added this, and it worked!

]
}
2 changes: 2 additions & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
save=true
save-exact=true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting to think that all of our projects should have these two config rules...

Loading