Trap focus in AnchoredOverlay as soon as it opens #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 637495a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/95wfsuuBm2tQysPs3BPQdd8NqqFw |
dgreif
force-pushed
the
anchored-overlay-always-trap
branch
from
a71315c to
637495a
Compare
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation of
AnchoredOverlay, the behavior for when to activate focus trapping is fairly complicated. If the user clicks or presses space/Enter to open the overlay, focus stays on the anchor. They can then use up/down arrow, enter, or tab to move focus into the overlay. If, however, they press up/down on the anchor initially, focus immediately moves into the overlay. In initial development, this felt like a good approach. However, real use has uncovered some corner cases which indicate the complex initial state might not be worth it. In particular, some newActionMenus that also include a text input, as well as theSelectPanel, need focus to be trapped as soon as the overlay is opened. The easiest solution is to simply always move focus into the overlay, rather than conditionally starting focus on the anchor.Closes #1210
Merge checklist