Handle onAction for DropdownMenu Items #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 47e5770 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/5p3CbLaaByYaxnsdwGycw98fvLo9 |
dgreif
force-pushed
the
refactor-dropdown-menu-on-action
branch
from
e90fa6e to
a6d24f9
Compare
VanAnderson
approved these changes
Apr 30, 2021
Merged
VanAnderson
pushed a commit
that referenced
this pull request
May 3, 2021
VanAnderson
pushed a commit
that referenced
this pull request
May 3, 2021
VanAnderson
added a commit
that referenced
this pull request
May 5, 2021
* Action Menu can be a controlled component with open state * update docs for ActionMenu * Create pink-lions-suffer.md * Handle onAction for DropdownMenu Items (#1194) * useProvidedStateOrCreate * linter fixes * update hook doc comment * Update src/hooks/useProvidedStateOrCreate.ts Co-authored-by: Dusty Greif <dgreif@users.noreply.github.com> * useProvidedOrCreateState has better implementation for generics * useProvidedOrCreateState has better implementation for generics * make string type explicit Co-authored-by: Dusty Greif <dgreif@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring
DropdownMenuto use the newonActioncallback fromActionList.Item, rather than handling click/key press manually. Also allowingitem.onActionto callevent.preventDefault(), which will now preventDropdownMenufrom closing and triggeringonChangeMerge checklist