chore(deps): update eslint-plugin-github to v4.10 (#3805)

* chore(deps): update eslint-plugin-github to v4.10 * test: update snapshots --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
primer · Oct 12, 2023 · b99b3ee · b99b3ee
1 parent 30b7dee
commit b99b3ee
Show file tree

Hide file tree

Showing 8 changed files with 223 additions and 37 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -199,7 +199,7 @@
     "cross-env": "7.0.3",
     "eslint": "8.40.0",
     "eslint-import-resolver-typescript": "3.6.0",
-    "eslint-plugin-github": "4.8.0",
+    "eslint-plugin-github": "4.10.1",
     "eslint-plugin-jest": "27.2.1",
     "eslint-plugin-jsx-a11y": "6.7.1",
     "eslint-plugin-mdx": "2.2.0",

diff --git a/src/FilterList/FilterList.tsx b/src/FilterList/FilterList.tsx
@@ -60,11 +60,7 @@ export type FilterListItemProps = {count?: number} & ComponentProps<typeof Filte
 const FilterListItem = ({children, count, ...rest}: React.PropsWithChildren<FilterListItemProps>) => {
   return (
     <FilterListItemBase {...rest}>
-      {count && (
-        <span title="results" className="count">
-          {count}
-        </span>
-      )}
+      {count && <span className="count">{count}</span>}
       {children}
     </FilterListItemBase>
   )

diff --git a/src/PageLayout/PageLayout.tsx b/src/PageLayout/PageLayout.tsx
@@ -798,6 +798,7 @@ const Pane = React.forwardRef<HTMLDivElement, React.PropsWithChildren<PageLayout
           {...(id && {id: paneId})}
         >
           {resizable && (
+            // eslint-disable-next-line github/a11y-no-visually-hidden-interactive-element
             <VisuallyHidden>
               <form onSubmit={handleWidthFormSubmit}>
                 <label htmlFor={`${paneId}-width-input`}>Pane width</label>

diff --git a/src/Select.tsx b/src/Select.tsx
@@ -50,7 +50,14 @@ const StyledSelect = styled.select`
 `
 
 const ArrowIndicatorSVG: React.FC<React.PropsWithChildren<{className?: string}>> = ({className}) => (
-  <svg width="16" height="16" fill="currentColor" xmlns="http://www.w3.org/2000/svg" className={className}>
+  <svg
+    aria-hidden="true"
+    width="16"
+    height="16"
+    fill="currentColor"
+    xmlns="http://www.w3.org/2000/svg"
+    className={className}
+  >
     <path d="m4.074 9.427 3.396 3.396a.25.25 0 0 0 .354 0l3.396-3.396A.25.25 0 0 0 11.043 9H4.251a.25.25 0 0 0-.177.427ZM4.074 7.47 7.47 4.073a.25.25 0 0 1 .354 0L11.22 7.47a.25.25 0 0 1-.177.426H4.251a.25.25 0 0 1-.177-.426Z" />
   </svg>
 )

diff --git a/src/Select/Select.tsx b/src/Select/Select.tsx
@@ -50,7 +50,14 @@ const StyledSelect = styled.select`
 `
 
 const ArrowIndicatorSVG: React.FC<React.PropsWithChildren<{className?: string}>> = ({className}) => (
-  <svg width="16" height="16" fill="currentColor" xmlns="http://www.w3.org/2000/svg" className={className}>
+  <svg
+    aria-hidden="true"
+    width="16"
+    height="16"
+    fill="currentColor"
+    xmlns="http://www.w3.org/2000/svg"
+    className={className}
+  >
     <path d="m4.074 9.427 3.396 3.396a.25.25 0 0 0 .354 0l3.396-3.396A.25.25 0 0 0 11.043 9H4.251a.25.25 0 0 0-.177.427ZM4.074 7.47 7.47 4.073a.25.25 0 0 1 .354 0L11.22 7.47a.25.25 0 0 1-.177.426H4.251a.25.25 0 0 1-.177-.426Z" />
   </svg>
 )

diff --git a/src/ToggleSwitch/ToggleSwitch.tsx b/src/ToggleSwitch/ToggleSwitch.tsx
@@ -53,6 +53,7 @@ type InnerIconProps = {size?: ToggleSwitchProps['size']}
 
 const CircleIcon: React.FC<React.PropsWithChildren<InnerIconProps>> = ({size}) => (
   <svg
+    aria-hidden="true"
     width={size === 'small' ? '12' : '16'}
     height={size === 'small' ? '12' : '16'}
     viewBox="0 0 16 16"
@@ -64,6 +65,7 @@ const CircleIcon: React.FC<React.PropsWithChildren<InnerIconProps>> = ({size}) =
 )
 const LineIcon: React.FC<React.PropsWithChildren<InnerIconProps>> = ({size}) => (
   <svg
+    aria-hidden="true"
     width={size === 'small' ? '12' : '16'}
     height={size === 'small' ? '12' : '16'}
     viewBox="0 0 16 16"

diff --git a/src/__tests__/__snapshots__/ToggleSwitch.test.tsx.snap b/src/__tests__/__snapshots__/ToggleSwitch.test.tsx.snap
@@ -239,6 +239,7 @@ exports[`renders consistently 1`] = `
         color="switchTrack.checked.fg"
       >
         <svg
+          aria-hidden="true"
           fill="currentColor"
           height="16"
           viewBox="0 0 16 16"
@@ -256,6 +257,7 @@ exports[`renders consistently 1`] = `
         color="switchTrack.fg"
       >
         <svg
+          aria-hidden="true"
           fill="currentColor"
           height="16"
           viewBox="0 0 16 16"