Add aria-selected value to ActionList.Item. (#3579)

* Add aria-selected value to ActionList.Item. * Create late-bugs-battle.md * Conditionally set aria-selected if role is option. * Linting and formatting. * Update src/ActionList/Item.tsx Co-authored-by: Josh Black <joshblack@github.com> * Update test so aria-selected gets generated correctly. --------- Co-authored-by: Josh Black <joshblack@github.com>
primer · Aug 16, 2023 · 66482a7 · 66482a7
1 parent 3bb6dc8
commit 66482a7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/late-bugs-battle.md b/.changeset/late-bugs-battle.md
@@ -0,0 +1,7 @@
+---
+"@primer/react": patch
+---
+
+Add aria-selected value to ActionList.Item.
+
+<!-- Changed components: ActionList -->
diff --git a/src/ActionList/Item.tsx b/src/ActionList/Item.tsx
@@ -207,6 +207,7 @@ export const Item = React.forwardRef<HTMLLIElement, ActionListItemProps>(
           ref={forwardedRef}
           sx={merge<BetterSystemStyleObject>(styles, sxProp)}
           data-variant={variant === 'danger' ? variant : undefined}
+          aria-selected={containerProps.role === 'option' ? selected : undefined}
           {...containerProps}
           {...props}
         >

diff --git a/src/__tests__/ActionList.test.tsx b/src/__tests__/ActionList.test.tsx
@@ -42,7 +42,6 @@ function SingleSelectListStory(): JSX.Element {
           key={index}
           role="option"
           selected={index === selectedIndex}
-          aria-selected={index === selectedIndex}
           onSelect={() => setSelectedIndex(index)}
           disabled={project.disabled}
         >