Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zod validation in action #692

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Zod validation in action #692

merged 1 commit into from
Jul 18, 2023

Conversation

lukasoppermann
Copy link
Contributor

Summary

Turning zod validation into an action

@lukasoppermann lukasoppermann requested a review from a team as a code owner July 18, 2023 15:30
@lukasoppermann lukasoppermann requested review from a team and langermank July 18, 2023 15:30
@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2023

⚠️ No Changeset found

Latest commit: e490e32

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

Variables changed
No variables changed

@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Jul 18, 2023
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 18, 2023 15:32 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 18, 2023 15:33 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 18, 2023 15:35 — with GitHub Actions Inactive
@lukasoppermann lukasoppermann changed the title basic zod validation Zod validation in action Jul 18, 2023
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 18, 2023 15:39 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 18, 2023 15:39 Inactive
@langermank langermank added the update snapshots Update visual regression test snapshots label Jul 18, 2023
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Jul 18, 2023
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe merging this will fix test failures in future PRs?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

Design Token Diff

/css/base/typography/typography.css

+++ /home/runner/work/primitives/primitives/tokens-next-private/css/base/typography/typography.css	2023-07-18 19:02:06.307855031 +0000
@@ -1,5 +1,5 @@
:root {
-  --base-text-weight-light: 300;
+  --base-text-weight-light: 350;
 --base-text-weight-normal: 400;
 --base-text-weight-medium: 500;
 --base-text-weight-semibold: 600;

@lukasoppermann lukasoppermann temporarily deployed to github-pages July 18, 2023 16:19 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 18, 2023 16:19 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 18, 2023 18:05 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 18, 2023 18:05 Inactive
@lukasoppermann lukasoppermann temporarily deployed to github-pages July 18, 2023 19:03 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 18, 2023 19:03 Inactive
@lukasoppermann lukasoppermann merged commit a09b12d into main Jul 18, 2023
23 of 25 checks passed
@lukasoppermann lukasoppermann deleted the zod-action branch July 18, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants