Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add additional shards for VRT #690

Merged
merged 5 commits into from
Jul 13, 2023
Merged

ci: add additional shards for VRT #690

merged 5 commits into from
Jul 13, 2023

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Jul 13, 2023 •
edited
Loading

Summary

Improve the performance of Visual Regression Tests by adding additional shards and removing the install browser step.

List of notable changes:

  • The number of shards for VRT has been increased to 4
  • The install browser step has been removed in preference of running the tests in a docker image

What should reviewers focus on?

  • The time it takes for the vrt-runner jobs to complete should reduce

Steps to test:

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8660019

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023 •
edited
Loading

Variables changed 
No variables changed

@joshblack joshblack added the skip changeset Apply to PRs that should not result in a version bump. label Jul 13, 2023
@joshblack joshblack temporarily deployed to github-pages July 13, 2023 14:55 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 13, 2023 14:55 Inactive
@joshblack joshblack temporarily deployed to github-pages July 13, 2023 15:13 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 13, 2023 15:14 Inactive
@joshblack joshblack temporarily deployed to github-pages July 13, 2023 15:17 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 13, 2023 15:17 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 13, 2023 15:23 Inactive
@joshblack joshblack added the update snapshots Update visual regression test snapshots label Jul 13, 2023
@joshblack joshblack marked this pull request as ready for review July 13, 2023 15:24
@joshblack joshblack requested a review from a team as a code owner July 13, 2023 15:24
lukasoppermann
lukasoppermann approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@lukasoppermann lukasoppermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Jul 13, 2023
@langermank langermank added skip changeset Apply to PRs that should not result in a version bump. and removed skip changeset Apply to PRs that should not result in a version bump. labels Jul 13, 2023
@langermank langermank merged commit c9f623e into main Jul 13, 2023
2 of 3 checks passed
@langermank langermank deleted the joshblack-patch-1 branch July 13, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasoppermann lukasoppermann lukasoppermann approved these changes

@broccolinisoup broccolinisoup Awaiting requested review from broccolinisoup

Assignees
No one assigned
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @lukasoppermann @langermank