Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve color contrast of light theme entity var #666

Merged
merged 4 commits into from
Jun 28, 2023

Conversation

ctmayn
Copy link
Contributor

@ctmayn ctmayn commented Jun 26, 2023

Summary

Adjust the value of entity highlighting so it meets the required color contrast on a diff deletion background.

This PR adjusts it from color-scale-purple-5 to color-scale-purple-6

Before:
Screenshot 2023-06-26 at 11 57 40 AM

After:
Screenshot 2023-06-26 at 11 58 19 AM

Fixes https://github.com/github/accessibility-audits/issues/3367

List of notable changes:

  • Update the color value of prettylights.syntax.entity to color-scale-purple-6

What should reviewers focus on?

  • Color changes and correct changeset

Steps to test:

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change
  • Verify the design tokens changed in this PR are expected using the diffing results in this PR

@ctmayn ctmayn requested a review from a team as a code owner June 26, 2023 18:59
@ctmayn ctmayn requested review from a team, simurai and josepmartins June 26, 2023 18:59
@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

🦋 Changeset detected

Latest commit: 1261bba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're in the middle of testing new color tokens, you'll need to make this change in two places: the file you already changed, and this one. Let me know when you make that change and I'll review again 😄

@langermank langermank merged commit 5c18c74 into primer:main Jun 28, 2023
@primer-css primer-css mentioned this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants