Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add playwright setup #623

Merged
merged 19 commits into from
Jul 12, 2023
Merged

test(e2e): add playwright setup #623

merged 19 commits into from
Jul 12, 2023

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Apr 27, 2023

Playwright snapshot tests help us track visual regressions by storing screenshots of all Storybook stories. This implementation will capture all stories, but we can always pair it down in the future if it seems like too much.

  • Add Playwright
  • Configure snapshot tests action to run on all PRs
  • Configure update snapshots label

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

⚠️ No Changeset found

Latest commit: b4c7cb6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2023

🟢 No design token changes found

@github-actions github-actions bot temporarily deployed to storybook-preview April 27, 2023 21:15 Inactive
@joshblack joshblack temporarily deployed to github-pages April 27, 2023 21:21 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview April 27, 2023 21:21 Inactive
@@ -97,3 +97,54 @@ jobs:

- name: Run unit tests
run: npm test

vrt-runner:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a name here that is more descriptive? So that it does not say CI / vrt

.github/workflows/ci.yml Show resolved Hide resolved
name: vrt-${{ matrix.shard }}
path: .playwright/report

vrt:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a name here that is more descriptive? So that it does not say CI / vrt-runner (1)

@joshblack
Copy link
Member Author

Hey @lukasoppermann! 👋 Just was putting this up as a draft from the pairing session @langermank and I had last week 👀 Let me know if it'd be preferred to leave it open as a draft or close it out.

@lukasoppermann
Copy link
Contributor

Hey @joshblack, so is this a working version of it already? Or does it need more work?

In any case, feel free to leave it here as a draft until it can get merged. Thanks for the help 🙏

@lukasoppermann lukasoppermann temporarily deployed to github-pages May 2, 2023 07:41 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview May 2, 2023 07:42 Inactive
@joshblack joshblack temporarily deployed to github-pages July 5, 2023 20:16 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 5, 2023 20:16 Inactive
@joshblack joshblack added the skip changeset Apply to PRs that should not result in a version bump. label Jul 5, 2023
@joshblack joshblack temporarily deployed to github-pages July 5, 2023 20:21 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 5, 2023 20:22 Inactive
@langermank langermank temporarily deployed to github-pages July 6, 2023 15:24 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 6, 2023 15:24 Inactive
@langermank langermank temporarily deployed to github-pages July 6, 2023 20:32 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 6, 2023 20:32 Inactive
@langermank langermank added the update snapshots Update visual regression test snapshots label Jul 7, 2023
@joshblack joshblack added the update snapshots Update visual regression test snapshots label Jul 7, 2023
@joshblack joshblack temporarily deployed to github-pages July 7, 2023 17:21 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 7, 2023 17:21 Inactive
@langermank langermank temporarily deployed to github-pages July 7, 2023 17:44 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 7, 2023 17:44 Inactive
@joshblack joshblack added update snapshots Update visual regression test snapshots and removed update snapshots Update visual regression test snapshots labels Jul 12, 2023
@joshblack joshblack temporarily deployed to github-pages July 12, 2023 17:17 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 12, 2023 17:18 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview July 12, 2023 17:18 Inactive
@joshblack joshblack added update snapshots Update visual regression test snapshots and removed update snapshots Update visual regression test snapshots labels Jul 12, 2023
@github-actions github-actions bot temporarily deployed to storybook-preview July 12, 2023 17:33 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Jul 12, 2023
@langermank langermank marked this pull request as ready for review July 12, 2023 18:13
@langermank langermank requested a review from a team as a code owner July 12, 2023 18:13
@langermank langermank requested review from a team and langermank July 12, 2023 18:13
@langermank langermank merged commit 6912893 into main Jul 12, 2023
24 checks passed
@langermank langermank deleted the add-playwright-setup branch July 12, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants