-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): add playwright setup #623
Conversation
|
🟢 No design token changes found |
@@ -97,3 +97,54 @@ jobs: | |||
|
|||
- name: Run unit tests | |||
run: npm test | |||
|
|||
vrt-runner: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a name here that is more descriptive? So that it does not say CI / vrt
name: vrt-${{ matrix.shard }} | ||
path: .playwright/report | ||
|
||
vrt: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a name here that is more descriptive? So that it does not say CI / vrt-runner (1)
Hey @lukasoppermann! 👋 Just was putting this up as a draft from the pairing session @langermank and I had last week 👀 Let me know if it'd be preferred to leave it open as a draft or close it out. |
Hey @joshblack, so is this a working version of it already? Or does it need more work? In any case, feel free to leave it here as a draft until it can get merged. Thanks for the help 🙏 |
Playwright snapshot tests help us track visual regressions by storing screenshots of all Storybook stories. This implementation will capture all stories, but we can always pair it down in the future if it seems like too much.
update snapshots
label