Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace jest with vitest #1001

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Replace jest with vitest #1001

merged 3 commits into from
Jul 10, 2024

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Jul 9, 2024 •
edited
Loading

Summary

The main reason for switching to vitest is that it supports esm out of the box.

This is need for updating to SDv4.

Updating is very straight forward, only jest.replaceProperty needed to be researched:

-  jest.replaceProperty(process, 'argv', [
+  vi.spyOn(process, 'argv', 'get').mockReturnValue([

@lukasoppermann lukasoppermann requested review from a team as code owners July 9, 2024 12:50
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 25ea5df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasoppermann lukasoppermann added dependencies Pull requests that update a dependency file skip changeset Apply to PRs that should not result in a version bump. labels Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Design Token Diff

No design tokens changed

@github-actions github-actions bot temporarily deployed to Preview (Storybook) July 10, 2024 06:56 Inactive
@lukasoppermann lukasoppermann merged commit 6c48139 into main Jul 10, 2024
24 checks passed
@lukasoppermann lukasoppermann deleted the vitest branch July 10, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukasoppermann