-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 7.3.0 #220
Merged
Merged
Release 7.3.0 #220
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9682355
Changing the lerna version preference to locked
jonrohan 7152b89
Build fix
jonrohan 949a9c1
Merge pull request #212 from primer/build_fix
jonrohan ac5bb87
Merge branch 'dev' into lerna_version_locked
jonrohan b59493d
Merge pull request #208 from primer/lerna_version_locked
jonrohan b83af5f
Updating changelog
jonrohan 48dbee4
v7.3.0
jonrohan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,5 +6,5 @@ | |
"lib/octicons_helper", | ||
"lib/jekyll-octicons" | ||
], | ||
"version": "independent" | ||
"version": "7.3.0" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
module Octicons | ||
VERSION = "5.3.0".freeze | ||
VERSION = "7.3.0".freeze | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
module OcticonsHelper | ||
VERSION = "4.3.0".freeze | ||
VERSION = "7.3.0".freeze | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,46 +1,5 @@ | ||
const got = require('got') | ||
|
||
// Translates a path based on the xy array passed in | ||
const translatePath = (p, xy) => { | ||
|
||
let ds = p.match(/([A-Z]{1,2}[\s0-9\.\-e]+)/g) | ||
let [x, y] = xy | ||
|
||
let dd = ds.map((d) => { | ||
var darr = d.split(" ").reverse() | ||
for(let i = 0; i < darr.length; i += 2) { | ||
if(darr[i+1]) { | ||
darr[i] = parseFloat(darr[i]) + y | ||
darr[i+1] = parseFloat(darr[i+1]) + x | ||
} | ||
} | ||
|
||
return darr.reverse().join(" ") | ||
}).join("") + "Z" | ||
|
||
return dd | ||
} | ||
|
||
// Gets the sum of all the `translate(x y)` and reduces it | ||
// <g transform="translate(-238 -286)"><g transform="translate(238 290)"> | ||
// becomes [0, 4] | ||
const reduceTranslate = (t) => { | ||
if(t == null) { | ||
return [0, 0] | ||
} | ||
if(t.length == 1) { | ||
return t[0].replace(/translate|[\(\)]/g,"").split(" ").map((v) => Math.round(parseFloat(v))) | ||
} | ||
return t.reduce((p,c) => { | ||
p = p.replace(/translate|[\(\)]/g,"").split(" ") | ||
c = c.replace(/translate|[\(\)]/g,"").split(" ") | ||
for(let i = 0; i < c.length; i++) { | ||
c[i] = Math.round(parseFloat(p[i])) + Math.round(parseFloat(c[i])) | ||
} | ||
return c | ||
}) | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A lot of this removal was taken care of in the svgo file changes above ☝️ |
||
module.exports = { | ||
progress: (current, total) => { | ||
let percentage = Math.ceil((current * 10) / total) | ||
|
@@ -60,19 +19,7 @@ module.exports = { | |
headers: { "Content-Type": "images/svg+xml" } | ||
}).on('downloadProgress', downloadProgress) | ||
|
||
let svg = response.body | ||
|
||
let d = svg.match(/ d=["']([a-z\s0-9\.\-]+)["']/i).pop() | ||
let translate = reduceTranslate(svg.match(/translate\([0-9\-\s\.e]+\)/g)) | ||
let d2 = translatePath(d, translate) | ||
|
||
// Clean and replace svg elements | ||
svg = svg.replace(`d="${d}"`, `d="${d2}"`) | ||
.replace(/<\/?defs>/g,"") | ||
.replace(/<use[^>]*>/g, "") | ||
|
||
resolve(svg) | ||
// .catch(err => reject(`There was trouble downloading ${url}\n${err}`)) | ||
resolve(response.body) | ||
}) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this get auto updated by lerna or do we have to manually update it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running the
npm run bump
command runs the appropriate lerna command which gives us a nice prompt for deciding.