Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update to lerna@2.1.1; use Yarn + workspaces #331

Closed
wants to merge 6 commits into from
Closed

Conversation

shawnbot
Copy link
Contributor

This PR updates to Lerna 2.1.1, uses Yarn for faster and more reliable dependency management, and uses Yarn's experimental workspaces feature to symlink dependencies during lerna bootstrap.

Bootstrapping from a clean install takes <30s on my little MacBook Air with this change! 🎉

TODO

  • Make sure it works on CI
  • Make sure that @broccolini and @jonrohan can run this locally without any problems

@shawnbot
Copy link
Contributor Author

FWIW, this is an approach adopted by Jest in this PR.

@shawnbot
Copy link
Contributor Author

Drat. I ran lerna clean and yarn clean locally, then npm test, and got the same error as on Travis.

@shawnbot
Copy link
Contributor Author

shawnbot commented Oct 4, 2017

This is too much to do in a single PR. Let's upgrade Lerna first, then try out Yarn workspaces.

@shawnbot shawnbot closed this Oct 4, 2017
@shawnbot shawnbot deleted the yarn branch October 17, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant