Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move native color styles from the color-modes bundle to the base bundle #2596

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Mar 26, 2024

What are you trying to accomplish?

These styles are meant to be browser setup, getting the background color correct and the various selectors for making the native form controls use dark/light.

I discovered that we needed to do this when removing the old color modes from primer_view_components it removed all the background colors. primer/view_components@5c81227 a similar thing happened in https://github.com/primer/react/pull/4352/files?file-filters%5B%5D=.css&file-filters%5B%5D=.js&file-filters%5B%5D=.json&show-deleted-files=true&show-viewed-files=true#diff-269990d48c898cb48f2ec7d9aeb437efe05c0c23aabccfdf079b9993a06ab8bcR9

Can these changes ship as is?

We should check to see if native.scss is imported in dotcom and update the url accordingly

@jonrohan jonrohan requested a review from a team as a code owner March 26, 2024 23:14
Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: 2ae20f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan merged commit 9896c79 into main Mar 29, 2024
12 checks passed
@jonrohan jonrohan deleted the move_native_color_styles branch March 29, 2024 20:04
@primer primer bot mentioned this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants