Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TextareaProps type And Image src props #6973

Merged
merged 9 commits into from
Dec 20, 2024
Merged

fix TextareaProps type And Image src props #6973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
aa5ad0a
fix: #5903
2234839 Jul 21, 2024
017ab81
renaming GlobalComponentConstructor https://github.com/primefaces/pri…
2234839 Sep 25, 2024
d58d141
Delete package-lock.json
2234839 Sep 26, 2024
9f27f5a
Merge commit '9d9ae356d07e599163a6b4b801c7a74f570a80cd'
2234839 Oct 9, 2024
33c2ce7
Update how component types are defined
2234839 Oct 9, 2024
e9e11fc
Merge branch 'primefaces:master' into master
2234839 Oct 21, 2024
35f31b4
Image props add src
2234839 Oct 21, 2024
6ae0325
Merge branch 'primefaces:master' into master
2234839 Dec 17, 2024
c7eeb8c
fix TextareaProps type
2234839 Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/primevue/src/image/Image.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,10 @@ export interface ImageState {
* Defines valid properties in Image component.
*/
export interface ImageProps {
/**
* Image url.
*/
src?: string | undefined;
/**
* Controls the preview functionality.
* @defaultValue false
Expand Down
4 changes: 2 additions & 2 deletions packages/primevue/src/textarea/Textarea.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import type { DefineComponent, DesignToken, EmitFn, Nullable, PassThrough } from '@primevue/core';
import type { ComponentHooks } from '@primevue/core/basecomponent';
import type { PassThroughOptions } from 'primevue/passthrough';
import { InputHTMLAttributes } from 'vue';
import type { TextareaHTMLAttributes } from 'vue';

export declare type TextareaPassThroughOptionType = TextareaPassThroughAttributes | ((options: TextareaPassThroughMethodOptions) => TextareaPassThroughAttributes | string) | string | null | undefined;

Expand Down Expand Up @@ -86,7 +86,7 @@ export interface TextareaContext {
/**
* Defines valid properties in Textarea component. In addition to these, all properties of TextareaHTMLAttributes can be used in this component.
*/
export interface TextareaProps extends Omit<InputHTMLAttributes, 'size'> {
export interface TextareaProps extends TextareaHTMLAttributes {
/**
* Value of the component.
*/
Expand Down
Loading