Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #5903 #6088

Merged
merged 5 commits into from
Oct 9, 2024
Merged

fix: #5903 #6088

merged 5 commits into from
Oct 9, 2024

Conversation

2234839
Copy link
Contributor

@2234839 2234839 commented Jul 21, 2024

###Defect Fixes
#5903

###Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.

@vercel Vercel
Copy link

vercel bot commented Jul 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 2:23am
primevue-v3 ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 2:23am

@tugcekucukoglu tugcekucukoglu added the Resolution: Help Wanted Issue or pull request requires extra help and feedback label Aug 2, 2024
@Eirmas Eirmas mentioned this pull request Sep 25, 2024
Closed
@Eirmas
Copy link

Eirmas commented Sep 25, 2024

I have tested this fix locally, and it works for all props, slots and emits!

I would suggest renaming GlobalComponentConstructor to something else as it's being being used outside the scope of GlobalComponents in this case.

@2234839
Copy link
Contributor Author

2234839 commented Sep 25, 2024

@Eirmas You're right. I made some brief changes, but I didn't test them enough

@Eirmas
Copy link

Eirmas commented Sep 26, 2024

@2234839 I think this looks good! If you remove package-lock.json that was generated from running with npm instead of pnpm, then I think this PR might have a big chance of getting merged faster :)

@Eirmas Eirmas mentioned this pull request Sep 26, 2024
Closed
@2234839
Copy link
Contributor Author

2234839 commented Sep 26, 2024

@Eirmas It was my oversight and the file has been removed

@Eirmas
Copy link

Eirmas commented Sep 26, 2024

@tugcekucukoglu Would you like to look into this PR?

@mertsincan
Copy link
Member

@2234839, Thanks a lot for your contribution! Could you please resolve conflicts? Then, I'll merge asap.

@mertsincan mertsincan removed the Resolution: Help Wanted Issue or pull request requires extra help and feedback label Oct 8, 2024
@mertsincan mertsincan added this to the 4.1.1 milestone Oct 8, 2024
@mertsincan mertsincan linked an issue Oct 8, 2024 that may be closed by this pull request
Typescript support is non-existent in All components #6152
Closed
@2234839
Copy link
Contributor Author

2234839 commented Oct 9, 2024

@mertsincan I handled a few conflicts, as well as new component type changes

@mertsincan mertsincan merged commit 1500542 into primefaces:master Oct 9, 2024
3 checks passed
@mertsincan
Copy link
Member

Perfect! Thanks a lot, @2234839 ;)

@tugcekucukoglu tugcekucukoglu removed this from the 4.1.1 milestone Oct 11, 2024
This was referenced Nov 11, 2024
Open
Open
tugcekucukoglu pushed a commit that referenced this pull request Dec 20, 2024
@2234839
fix TextareaProps type And Image src props (#6973)
95668a6 
* fix: #5903

* renaming GlobalComponentConstructor #6088 (comment)

* Delete package-lock.json

* Update how component types are defined

* Image props add src

* fix TextareaProps type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript support is non-existent in All components
4 participants
@2234839 @Eirmas @mertsincan @tugcekucukoglu