Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(DatePicker): allow to type the end date equal to the start date #6082

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Fix(DatePicker): allow to type the end date equal to the start date #6082

merged 1 commit into from
Aug 1, 2024

Conversation

KumJungMin
Copy link
Contributor

@KumJungMin KumJungMin commented Jul 18, 2024 •
edited
Loading

Defect Fixes

result

  • I modified the isValid value to allow the start date and end date to be the same.
if (this.isRangeSelection()) {
    isValid = value.length > 1 && value[1] > value[0] ? true : false; // before
}
if (this.isRangeSelection()) {
    isValid = value.length > 1 && value[1] >= value[0]; // after
}
2024-07-18.10.46.22.mov

@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 1:46pm
primevue-v3 ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 1:46pm

@KumJungMin KumJungMin marked this pull request as ready for review July 18, 2024 13:49
@tugcekucukoglu tugcekucukoglu merged commit 92ab5d5 into primefaces:master Aug 1, 2024
3 of 5 checks passed
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tugcekucukoglu tugcekucukoglu tugcekucukoglu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DatePicker: can not typing same date using input
2 participants
@KumJungMin @tugcekucukoglu