Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds custom target for OverlayPanel #942 #1379

Conversation

steineggerroland
Copy link

Fixes #942

Adds the second parameter target to OverlayPanel.show which is already documented in https://primefaces.org/primevue/showcase/#/overlaypanel and addressed by issue #942.

Citing the documentation:
target: Optional target if event.target should not be used

Here is probably still an issue, because the code uses event.currentTarget and not event.target as stated in the documentation.

@cagataycivici
Copy link
Member

Fixed on our side, thx. Still I think event.currentTarget is required, otherwise problems occur like overlay panel aligning it to an icon in the button, not the button itself.

@steineggerroland steineggerroland deleted the fix-issue-942 branch July 27, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom target for OverlayPanel
2 participants