Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Slots for Overlay Components #4433

Closed
cagataycivici opened this issue Sep 12, 2023 · 1 comment
Closed

Container Slots for Overlay Components #4433

cagataycivici opened this issue Sep 12, 2023 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@cagataycivici
Copy link
Member

cagataycivici commented Sep 12, 2023

For example, Toast, Dialog, Sidebar and OverlayPanel are good candidates for the container slot where entire content inside the root can be templated.

<p-toast>
   <template #container>
     Replaces the whole content, we should also pass close event handler to bind to custom UI
  </template>
</p-toast>

Related discussion;

https://github.com/orgs/primefaces/discussions/16

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Sep 12, 2023
@tugcekucukoglu
Copy link
Member

Toast and Dialog: 962ddb1

@tugcekucukoglu tugcekucukoglu added this to the 3.34.2 milestone Sep 19, 2023
tugcekucukoglu added a commit that referenced this issue Sep 19, 2023
tugcekucukoglu added a commit that referenced this issue Sep 19, 2023
tugcekucukoglu added a commit that referenced this issue Sep 19, 2023
tugcekucukoglu added a commit that referenced this issue Sep 19, 2023
tugcekucukoglu added a commit that referenced this issue Sep 19, 2023
tugcekucukoglu added a commit that referenced this issue Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants