Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column: Missing typing for sorticon #4423

Closed
Magiczne opened this issue Sep 11, 2023 · 1 comment · Fixed by #4859
Closed

Column: Missing typing for sorticon #4423

Magiczne opened this issue Sep 11, 2023 · 1 comment · Fixed by #4859
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.41.1

Comments

@Magiczne
Copy link
Contributor

Describe the bug

sorticon slot is not defining that the class is exposed in column/Column.d.ts line 946.

As can be seen in datatable/HeaderCell.vue in line 30 class is being exposed, and it's correctly containing .p-sortable-column-icon class

Reproducer

PrimeVue version

3.34.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Magiczne Magiczne added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 11, 2023
@Magiczne
Copy link
Contributor Author

@tugcekucukoglu is this gonna be addresses?

Magiczne pushed a commit to Magiczne/primevue that referenced this issue Nov 22, 2023
Fixed primefaces#4423: Column: Missing typing for sorticon
2369114
@Magiczne Magiczne mentioned this issue Nov 22, 2023
Merged
tugcekucukoglu added a commit that referenced this issue Nov 22, 2023
@tugcekucukoglu
Merge pull request #4859 from Magiczne/fix-4423
54d1f0a 
Fixed #4423: Column: Missing typing for sorticon
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 22, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.42.0 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.41.1
Development

Successfully merging a pull request may close this issue.

Fixed #4423: Column: Missing typing for sorticon Magiczne/primevue
2 participants
@Magiczne @tugcekucukoglu