Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload Missing TypeDefinitions for Callbacks in #content slot #3396

Closed
kaipaysen opened this issue Dec 13, 2022 · 0 comments · Fixed by #3422
Closed

FileUpload Missing TypeDefinitions for Callbacks in #content slot #3396

kaipaysen opened this issue Dec 13, 2022 · 0 comments · Fixed by #3422
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.22.0

Comments

@kaipaysen
Copy link

kaipaysen commented Dec 13, 2022 •
edited
Loading

Hi, thank you for your fix for #3335.

Unfortunately VSCode is now complaining about another location:
image

Same message for removeUploadedFileCallback and removeFileCallback.

image

I think the index parameter is missing.

Originally posted by @kaipaysen in #3335 (comment)
@tugcekucukoglu tugcekucukoglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 14, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.22.0 milestone Dec 14, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Dec 14, 2022
volvachev added a commit to volvachev/primevue that referenced this issue Dec 16, 2022
@volvachev
fix: type definition for fileUpload slot callbacks
3faf3d3 
Fixes primefaces#3396.
@volvachev volvachev mentioned this issue Dec 16, 2022
Closed
volvachev added a commit to volvachev/primevue that referenced this issue Dec 19, 2022
@volvachev
fix: type definition for fileUpload slot callbacks
f1da58a 
Fixes primefaces#3396.
@volvachev volvachev mentioned this issue Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.22.0
2 participants
@kaipaysen @tugcekucukoglu