Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon templating to Rating #2834

Closed
capoia opened this issue Aug 10, 2022 · 1 comment
Closed

Add icon templating to Rating #2834

capoia opened this issue Aug 10, 2022 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@capoia
Copy link

capoia commented Aug 10, 2022

Describe the feature you would like to see added

Hello how are you ?

I would like to change the rating component icons, using svg or the primeicons.
Something like vuetify already does.

Thanks!

Is your feature request related to a problem?

no.

Describe the solution you'd like

Put a slot for the filled icon and the empty icon

Describe alternatives you have considered

No response

Additional context

No response

@capoia capoia added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Aug 10, 2022
@bahadirsofuoglu bahadirsofuoglu added this to the 3.17.0 milestone Aug 26, 2022
@mertsincan mertsincan changed the title Rating - change icon Add icon templating to Rating Sep 8, 2022
@mertsincan
Copy link
Member

mertsincan commented Sep 8, 2022

Fixed in f0ae013

Added properties;

  • onIcon
  • offIcon
  • cancelIcon

Added slots;

  • onicon
  • officon
  • cancel

mertsincan added a commit that referenced this issue Sep 8, 2022
mertsincan added a commit that referenced this issue Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

4 participants