Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Dialog v2 containerStyle prop and modal leave defect #1957

Closed
wanglin86769 opened this issue Jan 10, 2022 · 3 comments
Closed

New Dialog v2 containerStyle prop and modal leave defect #1957

wanglin86769 opened this issue Jan 10, 2022 · 3 comments
Assignees
@yigitfindikli @tugcekucukoglu
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add vue2
Milestone
2.9.0

Comments

@wanglin86769
Copy link

For Primevue 2.7, if a modal and fixed-width Dialog contains Textarea, it appears from left to center with a shadow when it is opened.

Please refer to the following link,
https://codesandbox.io/s/stupefied-lichterman-ihupt
@tugcekucukoglu tugcekucukoglu added Status: Pending Review Issue or pull request is being reviewed by Core Team vue2 labels Jan 11, 2022
@tugcekucukoglu tugcekucukoglu changed the title Primevue 2.7 - Dialog containing Textarea appears abnormally when it is modal and fixed-width New Dialog v2 containerStyle prop and modal leave defect Feb 7, 2022
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Feb 7, 2022
@tugcekucukoglu tugcekucukoglu added this to the 2.9.0 milestone Feb 7, 2022
tugcekucukoglu added a commit that referenced this issue Feb 7, 2022
@tugcekucukoglu
Fixed #1957 - New Dialog v2 containerStyle prop and modal leave defect
6db8ab9
@tugcekucukoglu
Copy link
Member

Thanks for the codesandbox sample. This issue fixed for the next version.

@wanglin86769
Copy link
Author

@tugcekucukoglu Hello, I upgraded PrimeVue and found the problem still exists in 2.9.0, please refer to the following link:
https://codesandbox.io/s/modest-rhodes-lkxqz

@tugcekucukoglu
Copy link
Member

tugcekucukoglu commented Feb 11, 2022 •
edited
Loading

Please check this commit and new 'containerStyle' prop in the documentation.

It's a working example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

@tugcekucukoglu tugcekucukoglu

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add vue2
Projects
None yet
Milestone
2.9.0
Development

No branches or pull requests
3 participants
@yigitfindikli @tugcekucukoglu @wanglin86769