Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing props in ConfirmationOptions.d.ts #1852

Closed
ReevMich opened this issue Dec 8, 2021 · 2 comments · Fixed by #1853
Closed

Missing props in ConfirmationOptions.d.ts #1852

ReevMich opened this issue Dec 8, 2021 · 2 comments · Fixed by #1853
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.11.0

Comments

@ReevMich
Copy link
Contributor

ReevMich commented Dec 8, 2021

When running a production build of my application, im getting typescript errors of the property Header is not apart of type ConfirmationOptions in PrimeVue version 3.10.0.

I just forked the project and will submit a pull request shortly.
@ReevMich ReevMich mentioned this issue Dec 8, 2021
Merged
@NeluQi
Copy link

NeluQi commented Dec 9, 2021

Please fix it faster

@ReevMich
Copy link
Contributor Author

ReevMich commented Dec 9, 2021 •
edited
Loading

@NeluQi you should use the prior version to 3.10.0, as I am waiting for my PR #1853 to be reviewed and merged.

@tugcekucukoglu tugcekucukoglu changed the title Production Typescript Build Error: Missing props in ConfirmationOptions.d.ts Missing props in ConfirmationOptions.d.ts Dec 21, 2021
@tugcekucukoglu tugcekucukoglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 21, 2021
@tugcekucukoglu tugcekucukoglu added this to the 3.x milestone Dec 21, 2021
@tugcekucukoglu tugcekucukoglu self-assigned this Dec 21, 2021
tugcekucukoglu added a commit that referenced this issue Dec 21, 2021
@tugcekucukoglu
Refactor #1852
d52757a
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.x, 3.10.1 Dec 23, 2021
@MichaelVonB MichaelVonB mentioned this issue Jan 6, 2022
Closed
@tugcekucukoglu tugcekucukoglu mentioned this issue Jan 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.11.0
Development

Successfully merging a pull request may close this issue.

fix: added header and blockScroll props to confirmationoptions.d.ts ReevMich/primevue
3 participants
@ReevMich @NeluQi @tugcekucukoglu