Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event for file remove in FileUpload #1013

Closed
maherma-adg opened this issue Feb 23, 2021 · 0 comments
Closed

Event for file remove in FileUpload #1013

maherma-adg opened this issue Feb 23, 2021 · 0 comments
Assignees
@cagataycivici
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.5.0

Comments

@maherma-adg
Copy link

maherma-adg commented Feb 23, 2021 •
edited
Loading

FileUpdate component have events notifying select and clear file list, then you can track your selected items on component parent and clear the list when Cancel button is pressed, but when you press the (X) button in a item on list, you doesn't get any feedback, so you can't kept synchronized the internal list with the parent list.

I propose you to notify deletion of items with a new event "remove" to inform parent about item removal, argument for this event can be the list of remaining items or the removed item as you prefer.

I can do a PR if you agree with this proposal.
Regards
Manuel
pniedermeyer added a commit to pniedermeyer/primevue that referenced this issue Mar 3, 2021
@pniedermeyer
Add an remove event to FileUpload like in PrimeNg and PrimeReact.
eae92d3 
An 'remove' Event with the original Browser Event and the removed File ist emitted when a file is removed with the corresponding 'X' Button

Is this how do adjust the Doku?

PR to primefaces#1013
@pniedermeyer pniedermeyer mentioned this issue Mar 3, 2021
Closed
@cagataycivici cagataycivici added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add priority - low labels May 10, 2021
@cagataycivici cagataycivici changed the title FileUpload: Delete selected item is not notified Event for file remove in FileUpload May 10, 2021
@cagataycivici cagataycivici self-assigned this May 11, 2021
@cagataycivici cagataycivici added this to the 3.5.0 milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.5.0
Development

No branches or pull requests
2 participants
@cagataycivici @maherma-adg