Merge pull request #4600 from FlipWarthog/test-fix

Fix #4599 - PR Checker build failing
primefaces · Oct 13, 2023 · eda7998 · eda7998
2 parents 730c615 + bc4d879
commit eda7998
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/components/lib/button/Button.spec.js b/components/lib/button/Button.spec.js
@@ -79,6 +79,6 @@ describe('Button.vue', () => {
             }
         });
 
-        expect(wrapper.html()).toBe(`<button class="p-button p-component" type="button" data-pc-name="button" data-pc-section="root" data-pd-ripple="true"><span class="ml-2 font-bold">Default PrimeVue Button</span></button>`);
+        expect(wrapper.html()).toBe(`<button class="p-button p-component" type="button" data-pc-name="button" data-pc-section="root"><span class="ml-2 font-bold">Default PrimeVue Button</span></button>`);
     });
 });
diff --git a/components/lib/rating/Rating.spec.js b/components/lib/rating/Rating.spec.js
@@ -37,7 +37,7 @@ describe('Rating.vue', () => {
     it('When star is clicked, onOptionClick method should triggered', async () => {
         await wrapper.find('.p-rating-item').trigger('click');
 
-        expect(wrapper.find('.p-focus').exists()).toBe(true);
+        expect(wrapper.find('[data-p-focused="true"]').exists()).toBe(true);
     });
 
     it('When input focused, focusedOptionIndex value should changed', async () => {

diff --git a/components/lib/splitbutton/SplitButton.vue b/components/lib/splitbutton/SplitButton.vue
@@ -80,7 +80,10 @@ export default {
     },
     methods: {
         onDropdownButtonClick(event) {
-            event.preventDefault();
+            if (event) {
+                event.preventDefault();
+            }
+
             this.$refs.menu.toggle({ currentTarget: this.$el, relatedTarget: this.$refs.button.$el });
             this.isExpanded = this.$refs.menu.visible;
         },

diff --git a/vitest.config.js b/vitest.config.js
@@ -11,6 +11,9 @@ export default mergeConfig(
         test: {
             globals: true,
             environment: 'jsdom',
+            onConsoleLog: (log, type) => {
+                if (type === 'stderr' && log.includes('Could not parse CSS stylesheet')) return false;
+            },
             coverage: {
                 provider: 'istanbul',
                 reporter: ['text', 'json', 'html']
-Original file line number
+Diff line change
@@ Expand Up / @@ -79,6 +79,6 @@ describe('Button.vue', () => { @@
                 }
             });
-            expect(wrapper.html()).toBe(`<button class="p-button p-component" type="button" data-pc-name="button" data-pc-section="root" data-pd-ripple="true"><span class="ml-2 font-bold">Default PrimeVue Button</span></button>`);
+            expect(wrapper.html()).toBe(`<button class="p-button p-component" type="button" data-pc-name="button" data-pc-section="root"><span class="ml-2 font-bold">Default PrimeVue Button</span></button>`);
         });
     });