Remove null check from Dropdown getSelectedOptionIndex() #7371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently setting props.value to null clears the dropdown even if an option with a null value is present. This allows for null option values in Dropdowns again. Functionally it's fully compatible - if the options don't contain a null option, the return value will be -1 and the dropdown will be cleared as before. There might be a small performance hit if anyone has used value=null to clear the selection of a dropdown with lots of entries.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7370
Currently setting
props.valueto null clears the dropdown even if an option with a null value is present.This allows for null option values in Dropdowns again.
Functionally it's fully compatible - if the options don't contain a null value option, the function's return value will be -1 and the dropdown will be cleared as before.
There might be a small performance hit if
value=nullis used to clear the selection of a dropdown with lots of entries.