-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Issue 7329 #7360
Fix for Issue 7329 #7360
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Weird I am not seeing the OnToggle errors you are seeing we do a ts-check on the build of every PR? |
For example the build runs |
That's weird then: When I clone the current repository and execute the command from above, I am instantly getting the error |
let me check |
That is what happens when I run from Main right now? |
I think I had a version mismatch with next. I had already installed next 14.2.15 before cloning and my IDE changed the package.json versions without letting me know... |
OK can you revert all those changes then? I think this PR gets a lot smaller 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert all unnecessary changes
I have reverted the changes. I have also added some comments in the corresponding issue, as I am not entirely sure, where the className and style are lost in the getPTValue() call or where they should/would be added, respectively. Could you take a look into it? |
Fix #7329
This pull request should fix issue #7329 by adding RowBase.getProps to the mergeProps call.
I have also added changes due to two build issues that I have encountered: