Fix #7180 Screenreader improve hidden accessible #7179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
melloware
requested review from
tugcekucukoglu,
mertsincan,
cagataycivici and
nitrogenous
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
melloware
added
the
Component: Accessibility
melloware
changed the title
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
melloware
force-pushed
the
p-sr-readonly
branch
from
44e1beb to
723e03f
Compare
melloware
force-pushed
the
p-sr-readonly
branch
from
723e03f to
258d37b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7180 Screenreader improve hidden accessible
Based on this PF ticket: primefaces/primefaces#12577
Based on NVDA: nvaccess/nvda#16300
This is the modern way to hide things but still make them screenreader visible. Tested with JAWS and NVDA
NOTE: There are two styles
p-hidden-accessibleandp-sr-onlyand PrimeTek should standardize on one and it looks like PrimeVue standardized onp-hidden-accessible