Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(InputNumber): remove styled true option in useHandleStyle #6980

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

KumJungMin
Copy link
Contributor

@KumJungMin KumJungMin commented Aug 3, 2024

Defect Fixes


how to resolve?

  • The default CSS for inputNumber is currently not being applied.
  • The issue originated from a previous PR where a bug with the unstyled option was fixed, resulting in styled: true being set, which prevented the default styles from being applied.
스크린샷 2024-08-03 오후 9 05 48
  • Therefore, I have removed the styled: true option :)

Test

1. Check the style of inputNumber.

스크린샷 2024-08-03 오후 9 13 20 스크린샷 2024-08-03 오후 9 13 09

2. Check the unstyled option for inputNumber.

<InputNumber
    unstyled    <!-- check -->
    inputId="horizontal-buttons"
    value={value2}
    onValueChange={(e) => setValue2(e.value)}
    showButtons
    buttonLayout="horizontal"
    step={0.25}
    decrementButtonClassName="p-button-danger"
    incrementButtonClassName="p-button-success"
    incrementButtonIcon="pi pi-plus"
    decrementButtonIcon="pi pi-minus"
    mode="currency"
    currency="EUR"
/>
스크린샷 2024-08-03 오후 9 12 55

Copy link

vercel bot commented Aug 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2024 0:05am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2024 0:05am

@KumJungMin KumJungMin changed the title fix: remove styled true option in useHandleStyle Fix(InputNumber): remove styled true option in useHandleStyle Aug 3, 2024
@KumJungMin KumJungMin marked this pull request as ready for review August 3, 2024 12:15
@melloware melloware merged commit 11126ad into primefaces:master Aug 3, 2024
9 checks passed
@melloware
Copy link
Member

THanks @KumJungMin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputGroup: Input field do not show correctly
2 participants