Fix #6908: Missing props in MessagesPassThroughMethodOptions and MessagesProps #6909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
melloware
requested changes
Jul 19, 2024
| @@ -22,6 +22,9 @@ export declare type MessagesPassThroughTransitionType = ReactCSSTransitionProps | |||
| */ | |||
| export interface MessagesPassThroughMethodOptions { | |||
| props: MessagesProps; | |||
| state: MessagesState; | |||
| hostName?: string; | |||
There was a problem hiding this comment.
I will have to look. What is hostname? Weird property for messages.
There was a problem hiding this comment.
Since last release I see that prop in some components... I don't know what it is neither. If you see my PR #6902 in the stackblitz reproducer, you will see that prop also for bodyRow in Datatable component.
I only include that prop here because it is passed through MessagesPassThroughMethodOptions.
melloware
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fix #6908