Fix #6809: Make sure editable dropdown opens when user types

[peconomou929]

Fix #6809.

This bug did not always exist. It was first introduced in #6032.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
primereact	⬜️ Ignored (Inspect)	Visit Preview		Jul 1, 2024 11:15am
primereact-v9	⬜️ Ignored (Inspect)	Visit Preview		Jul 1, 2024 11:15am

[github-actions]

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

[melloware]

@peconomou929 can you retest the issue in #6027 that caused me to make the original change please?

[melloware]

I must have had a good reason to make this change

[peconomou929]

@melloware I am testing my changes with a dropdown that has filter=true and editable=true and the issue in #6027 is not present.

[melloware]

Nice! From looking at this code again it has me wondering. Why don't show() and hide() just check the overlayvisible state instead of everywhere in the code?

Like for example:

const show = () => {
            if (overlayVisibleState) return;

            setFocusedOptionIndex(focusedOptionIndex !== -1 ? focusedOptionIndex : props.autoOptionFocus ? findFirstFocusedOptionIndex() : props.editable ? -1 : findSelectedOptionIndex());
            setOverlayVisibleState(true);
        };

I know its not related to your PR but doesn't it make sense that show() and hide() would just check the overlayVisibleState?

[peconomou929]

Nice! From looking at this code again it has me wondering. Why don't show() and hide() just check the overlayvisible state instead of everywhere in the code?

Hmm, I see your point. It might make sense to do that, but I'm not entirely sure it's a good idea (for now at least). For example, the hide function is

const hide = () => {
    setOverlayVisibleState(false);
    clickedRef.current = false;
};

In addition to setting the visible state, it also sets the clickedRef. What if somebody calls the hide function (perhaps one of the current usages of hide) and expects the clickedRef to always be set to false?

[melloware]

ok i will take a look!