Fix: Cannot npm link primereact on local project #6619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
melloware
approved these changes
May 13, 2024
melloware
added
the
Component: Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fix #6620: following the DEVELOPMENT.MD documentation, I couldn't import the modules into another React project. In addition, warnings were sometimes given that certain variables would be undefined in the Gulp script (not always reproduced).
I therefore modified the way variables are set in Windows bash (cmd), and moved a command so that it wouldn't block the execution of subsequent commands, enabling styles and templates to be generated in the dist/resources folder, and also generating the components' .json package.
Without the fix :
Generated dist folder :
With the fix :
Generated dist folder :
To be tested to be sure of the fix, for me it works every time on a Windows and a Linux :)