Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #6487 Splitter can work with multiple panels #6490

Merged

Conversation

KirilCycle
Copy link
Contributor

@KirilCycle KirilCycle commented Apr 28, 2024

Fix #6487

Description

Works fine

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 2:41pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 2:41pm

Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@KirilCycle KirilCycle changed the title Fix: Splitter can work with multiple panels Fix: #6487 Splitter can work with multiple panels Apr 28, 2024
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@nitrogenous nitrogenous added Status: Pending Review Issue or pull request is being reviewed by Core Team Status: Pending Test Issue or pull request is being tested by Core Team labels Apr 29, 2024
@KirilCycle KirilCycle marked this pull request as ready for review April 29, 2024 14:37
@melloware
Copy link
Member

Nice PR!

@melloware melloware force-pushed the fix/splitter-with-multi-panels branch from 2ce796e to 36a99a9 Compare April 29, 2024 14:40
@nitrogenous nitrogenous added this to the 10.6.4 milestone Apr 29, 2024
Copy link
Contributor

@nitrogenous nitrogenous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job! Thanks!

@nitrogenous nitrogenous removed Status: Pending Review Issue or pull request is being reviewed by Core Team Status: Pending Test Issue or pull request is being tested by Core Team labels Apr 30, 2024
@nitrogenous nitrogenous merged commit 378a167 into primefaces:master Apr 30, 2024
5 checks passed
@nitrogenous nitrogenous removed this from the 10.6.4 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants