-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6464: PrimeIcons v7 constants #6465
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
ARROW_CIRCLE_LEFT: 'pi .pi-arrow-circle-left', | ||
ARROW_CIRCLE_RIGHT: 'pi .pi-arrow-circle-right', | ||
ARROW_CIRCLE_UP: 'pi .pi-arrow-circle-up', | ||
ARROW_DOWN_LEFTANDARROW_UP_RIGHT_TO_CENTER: 'pi .pi-arrow-down-left-and-arrow-up-right-to-center', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some missing underscores around "AND" here.
Also, I count 311 icons in the documentation – how come there are 314 entries here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melloware It is "pi-circle-off", "pi-circle-on" and "pi-file-o" that are defined here but aren't listed in the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied the names of the icons right from primeicons.css using regex and those values don't have underscores in the icon name so I kept them exact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ARROW_UP_RIGHT_AND_ARROW_DOWN_LEFT_FROM_CENTER" does have underscores, though, and reads much nicer.
WINDOW_MINIMIZE: 'pi pi-window-minimize', | ||
WRENCH: 'pi pi-wrench', | ||
YOUTUBE: 'pi pi-youtube' | ||
ADDRESS_BOOK: 'pi .pi-address-book', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, careful here! In the previous version, there was no period before the class name, but now there is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh yeah I need to remove the period.
Fix #6464: PrimeIcons v7 constants