-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/#6144 htmlFor prop doesn't work in MultiStateCheckBox #6195
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
Did you check if PrimeVue has the same issue or has the same |
It looks like more than just this label is broken on the showcase the MultiState checkbox doesn't ever seem to get checked? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I htink we need to investigate why the icons are not appearing also.
I will take a look. |
OK I fixed the icons in my PR: #6209 |
Hi, Similar to #6210 (comment) We'll have added new structures for the next version. For now, closed. Thanks a lot for your PR! |
Defect Fixes
Fix: #6144 htmlFor prop doesn't work in MultiStateCheckBox