Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/#6144 htmlFor prop doesn't work in MultiStateCheckBox #6195

Closed
wants to merge 6 commits into from

Conversation

charithAmila
Copy link
Contributor

@charithAmila charithAmila commented Mar 21, 2024

Defect Fixes

Fix: #6144 htmlFor prop doesn't work in MultiStateCheckBox

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 4:20pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 4:20pm

Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@charithAmila charithAmila marked this pull request as ready for review March 21, 2024 02:41
@charithAmila charithAmila changed the title fix/#6144 fix/#6144 htmlFor prop doesn't work in MultiStateCheckBox Mar 21, 2024
@melloware
Copy link
Member

Did you check if PrimeVue has the same issue or has the same
Solution?

@melloware
Copy link
Member

It looks like more than just this label is broken on the showcase the MultiState checkbox doesn't ever seem to get checked?

Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I htink we need to investigate why the icons are not appearing also.

@melloware melloware added the Status: In Progress Core Team is working on the issue or pull request label Mar 21, 2024
@charithAmila
Copy link
Contributor Author

I will take a look.

@charithAmila
Copy link
Contributor Author

charithAmila commented Mar 21, 2024

I htink we need to investigate why the icons are not appearing also.

The icons do not appear because both the background and icon colors are same.

Dark mode preview:
Screen Shot 2024-03-21 at 11 30 42 AM

Suggestion 1:
Add styles to theme.css

. p-multistatecheckbox  > .p-highlight {
     background: '#8dd0ff'; // Any color
     boarder-color: '#8dd0ff'; // Any color
}

Suggestion 2:
We should add a default color to the icon or parent element (div)

Results:

  1. Added primary color to the parent element.
Screen Shot 2024-03-21 at 11 17 35 AM
  1. Added primary color to the icon.
Screen Shot 2024-03-21 at 11 23 47 AM

@melloware
Copy link
Member

OK I fixed the icons in my PR: #6209

@charithAmila charithAmila requested a review from melloware March 21, 2024 16:37
@mertsincan
Copy link
Member

Hi,

Similar to #6210 (comment)

We'll have added new structures for the next version. For now, closed. Thanks a lot for your PR!

@mertsincan mertsincan closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress Core Team is working on the issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiStateCheckBox: htmlFor prop doesn't work
3 participants