Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix primefaces #4875 InputNumber: Doesn't allow minus sign in currency mode #4881

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

akshayantony55
Copy link
Contributor

@akshayantony55 akshayantony55 commented Sep 6, 2023

Defect Fixes

Fix #4875 InputNumber: Doesn't allow minus sign in currency mode
Fix #4875

@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2023 0:37am

Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this makes sense as rootProps.min will always be NULL right?

@akshayaqburst
Copy link
Contributor

@melloware I have slightly adjusted my code. When min is not passed to the InputNumber component, props.min has value undefined and rootProps.min has value of null.

Co-authored-by: Melloware <mellowaredev@gmail.com>
@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label Sep 6, 2023
@melloware melloware merged commit 0f08c4b into primefaces:master Sep 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputNumber: Doesn't allow minus sign in currency mode
3 participants