Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow additional props from IconType to expose additional props in base object #4642

Merged
merged 4 commits into from
Jul 11, 2023
Merged

feat: allow additional props from IconType to expose additional props in base object #4642

merged 4 commits into from
Jul 11, 2023

Conversation

EmirBoyaci
Copy link
Contributor

Closes #4639

@vercel
Copy link

vercel bot commented Jul 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Jul 11, 2023 4:49pm

@EmirBoyaci
Copy link
Contributor Author

cc: @melloware

@EmirBoyaci
Copy link
Contributor Author

Not sure about naming but didn't wanted to give more time to choose what is the best naming for generics, feel free to suggest re-naming.

@melloware
Copy link
Member

so far I like the look of it. Let me test it out later today!

@EmirBoyaci
Copy link
Contributor Author

so far I like the look of it. Let me test it out later today!

Sounds good. With adding AdditionalProps generic, we also add ability to define custom additional properties for specific cases as like in this.
So, in the future I think we can delete [key: string]: any; to make sure all properties exactly matches with the type definitions.

@melloware melloware added the Typescript Issue or pull request is *only* related to TypeScript definition label Jul 11, 2023
@melloware
Copy link
Member

You might be right i hopefully will be able to play around with your PR later today to see if I run into any issues.

@melloware
Copy link
Member

I just made one small change and some docs but this is working great!

@melloware melloware merged commit 2b7f7af into primefaces:master Jul 11, 2023
@EmirBoyaci EmirBoyaci deleted the feat-4639 branch July 11, 2023 17:03
@alperari alperari mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataTable: The parameter of the function passed to sortIcon has the wrong type
2 participants
@EmirBoyaci @melloware