Fixes #4350: updates incorrectly replacing old state instead of actual #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
|
Please open an issue with a reproducer showing your issue. |
|
fixes #4350 |
|
repro (also in linked issue) |
|
let me do some testing with this PR. Also My guess is similar fixes need to be done to Messages as its similar to Toast. |
melloware
requested changes
May 8, 2023
melloware
added
the
Status: Pending Review
melloware
changed the title
ecstrema
added a commit
to ecstrema/primereact
that referenced
this pull request
May 9, 2023
|
Ok I will test today. Yeah so far I have left them separate and not refactored just for fear there would be something different in the two but I will look today. |
melloware
removed
the
Status: Pending Review
melloware
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4350