Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'showWeek' prop throws an error with TypedScript on Calendar #926

Closed
emiravete opened this issue Jun 19, 2019 · 1 comment
Closed

The 'showWeek' prop throws an error with TypedScript on Calendar #926

emiravete opened this issue Jun 19, 2019 · 1 comment
Assignees
@mertsincan
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
3.1.5

Comments

@emiravete
Copy link
Contributor

After installing the release 3.1.4 a compilation issue occurs when we try to build our application

modules/primereact/components/calendar/Calendar.d.ts(56,15):
TS2503: Cannot find namespace 'PropTypes'.

The line 56 of file Calendar.d.ts is defined as showWeek: PropTypes.bool
But we don't understand why this boolean property is differently defined as the others and we think that is an error. We suggest to replace by showWeek?: boolean
emiravete added a commit to emiravete/primereact that referenced this issue Jun 19, 2019
@emiravete
Update Calendar.d.ts
201ad27 
Fix for the issue primefaces#926
@emiravete emiravete mentioned this issue Jun 19, 2019
Merged
@mertsincan mertsincan self-assigned this Jun 19, 2019
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Jun 19, 2019
@mertsincan mertsincan added this to the 3.1.5 milestone Jun 19, 2019
@mertsincan mertsincan changed the title Release 3.1.4 compilation issue in TypedScript the 'showWeek' prop throws an error with TypedScript on Calendar Jun 19, 2019
@mertsincan mertsincan changed the title the 'showWeek' prop throws an error with TypedScript on Calendar The 'showWeek' prop throws an error with TypedScript on Calendar Jun 19, 2019
@mertsincan
Copy link
Member

Thanks a lot for the PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
3.1.5
Development

No branches or pull requests
2 participants
@mertsincan @emiravete