Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter: Does not work with space #7529

Closed
ViniciusLima7 opened this issue Dec 26, 2024 · 9 comments · Fixed by #7530
Closed

Filter: Does not work with space #7529

ViniciusLima7 opened this issue Dec 26, 2024 · 9 comments · Fixed by #7530
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@ViniciusLima7
Copy link

Describe the bug

When using a filter from the Table and trying to search for a compound word containing spaces, the Filter does not recognize spaces

Example: When trying to search for “ABC DEF” the input displays “ABCDEF” , completely ignoring the space.

{2C4F2060-DDCB-4269-B1F4-E1A03647A002}

Below is a link to the documentation itself to reproduce the problem in the Name column.

Reproducing the Error:
https://stackblitz.com/edit/s978vv5g?file=src%2FApp.jsx

Apparently, there is a conflict between the sortable and filter props. When you remove the sortable prop from the Name column, the space works again in the filters.

{44EC4746-7514-46ED-84A3-E91B7C7BA818}

The ideal solution is for these two props to work together without this problem

Reproducer

https://stackblitz.com/edit/s978vv5g?file=src%2FApp.jsx

System Information

primereact: 10.8.5
react: 18.3.1

Steps to reproduce the behavior

Go to this url: https://stackblitz.com/edit/s978vv5g?file=src%2FApp.jsx then try to filter using space, preferably the Name or Country column.

Expected behavior

The ideal solution is for these two props to work together without this problem of the filter with space.

@ViniciusLima7 ViniciusLima7 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 26, 2024
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 27, 2024
@wmortume
Copy link

I have the same issue... going back to the previous version "10.8.4" is a temporary fix.

@melloware
Copy link
Member

Have a feeling it was this fix: #7451

@ViniciusLima7
Copy link
Author

I have the same issue... going back to the previous version "10.8.4" is a temporary fix.

In version “10.8.3”, this problem also occurs.

@melloware
Copy link
Member

@wmortume are you saying it works in 10.8.4 but @ViniciusLima7 says it doesn't so is this NOT a new issue?

@wmortume
Copy link

@melloware I'm only seeing the issue in "10.8.5". It works on "10.8.4" and "10.8.3" for me.

@ViniciusLima7
Copy link
Author

In version “10.8.4” I haven't tested it, but in version “10.8.3” the problem also occurs, but it depends on the environment, in developer mode it works fine in version “10.8.3”, but in the staging environment it doesn't work for some reason.
I don't know if this is linked to the fact that my staging environment is linux and the development environment is windows.

I'd have to investigate Primereact's native code to be sure.

I believe that solving this problem in the latest release is already fine.

@ViniciusLima7
Copy link
Author

Thank you very much @melloware for fixing the problem so quickly. I just have one question: will this fix come in the next version, 10.8.6?

@melloware
Copy link
Member

I marked it for 10.8.6 yes

@ViniciusLima7
Copy link
Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants