Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu: Ability to highlight the disabled item #7508

Closed
mikejav opened this issue Dec 16, 2024 · 3 comments · Fixed by #7537
Closed

Menu: Ability to highlight the disabled item #7508

mikejav opened this issue Dec 16, 2024 · 3 comments · Fixed by #7537
Labels
Type: Bug Issue contains a defect related to a specific component.

Comments

@mikejav
Copy link

mikejav commented Dec 16, 2024

Describe the bug

It's possible to hover over the disabled item in the Menu component and achieve the "highlighted item" effect.
It's not possible to select it using the keyboard though.

gif3

Reproducer

https://stackblitz.com/edit/qhjakw4h-7hq2pvpg?file=src%2FApp.jsx

System Information

System:
    OS: Windows 10 10.0.19045
    CPU: (12) x64 Intel(R) Core(TM) i5-10400F CPU @ 2.90GHz 
    Memory: 17.13 GB / 31.93 GB
  Binaries:
    Node: 20.10.0 - C:\Program Files\NodeJS 20.10.0\node.EXE
    npm: 10.2.3 - C:\Program Files\NodeJS 20.10.0\npm.CMD
  Browsers:
    Edge: Chromium (131.0.2903.51)
    Internet Explorer: 11.0.19041.4355
  npmPackages:
    primereact: ^10.8.5 => 10.8.5
    react: ^18.2.0 => 18.2.0

Steps to reproduce the behavior

  1. Go to https://stackblitz.com/edit/qhjakw4h-7hq2pvpg?file=src%2FApp.jsx
  2. Open the Menu and hover over the second menu item (disabled one)

Expected behavior

It shouldn't be possible to achieve the "highlighted item" effect on the disabled menu item.

@mikejav mikejav added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 16, 2024
@akshayaqburst
Copy link
Contributor

I will work on this issue

@akshayaqburst
Copy link
Contributor

@melloware Please review and merge

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 31, 2024
melloware added a commit to melloware/primereact that referenced this issue Dec 31, 2024
@melloware
Copy link
Member

@akshayaqburst check out my PR which is the correct way to fix it: #7537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
3 participants