Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable : fix ColumnFilter aria-controls #7166

Closed
kyybo opened this issue Sep 12, 2024 · 0 comments · Fixed by #7167 · May be fixed by leoo1992/GeradorQRCode#95
Closed

DataTable : fix ColumnFilter aria-controls #7166

kyybo opened this issue Sep 12, 2024 · 0 comments · Fixed by #7167 · May be fixed by leoo1992/GeradorQRCode#95
Assignees
@kyybo
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Milestone
10.8.3

Comments

@kyybo
Copy link
Contributor

kyybo commented Sep 12, 2024

Describe the bug

I think that the aria-controls attribute of the column filter button (in Datatable component) should only be set when the popup menu is visible in the DOM, otherwise a screen reader will give you a hint that you can move to the controlled element but it will have no effect because the controlled element doesn't exist.

Reproducer

No response

System Information

"primereact": "10.8.2"
"react": "^18.2.0"

Steps to reproduce the behavior

No response

Expected behavior

No response
@kyybo kyybo added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 12, 2024
kyybo added a commit to kyybo/primereact that referenced this issue Sep 12, 2024
@kyybo
Fix primefaces#7166 - Datatable : fix ColumnFilter aria-controls
09b3067 
Set 'aria-controls' for ColumnFilter only when the menu filter is visible.

fix primefaces#7166
@kyybo kyybo mentioned this issue Sep 12, 2024
Merged
@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 12, 2024
@melloware melloware added this to the 10.8.3 milestone Sep 12, 2024
@leoo1992 leoo1992 mentioned this issue Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyybo kyybo

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Projects
None yet
Milestone
10.8.3
2 participants
@melloware @kyybo